Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine the description of EXPLAIN #16926

Merged
merged 2 commits into from
Apr 7, 2024
Merged

refine the description of EXPLAIN #16926

merged 2 commits into from
Apr 7, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Mar 28, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.4 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Mar 28, 2024
@Oreoxmt Oreoxmt self-assigned this Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2024
@Oreoxmt Oreoxmt requested a review from qiancai March 29, 2024 07:02
qiancai
qiancai approved these changes Apr 7, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 7, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-07 06:41:55.840992102 +0000 UTC m=+771777.368532647: ☑️ agreed by qiancai.

@Oreoxmt @qiancai
Apply suggestions from code review
c26b989 
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt added the lgtm label Apr 7, 2024
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Apr 7, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit f223bfb into pingcap:master Apr 7, 2024
7 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #16992.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #16993.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.4: #16994.

This was referenced Apr 7, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #16995.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.6: #16996.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 7, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
refine the description of EXPLAIN (#16926) (#16996)
df1fc71
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
refine the description of EXPLAIN (#16926) (#16992)
4405b48
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
refine the description of EXPLAIN (#16926) (#16993)
ccd9d38
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
refine the description of EXPLAIN (#16926) (#16994)
4bff0f9
ti-chi-bot bot pushed a commit that referenced this pull request Apr 7, 2024
@ti-chi-bot
refine the description of EXPLAIN (#16926) (#16995)
dfee571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oreoxmt @ti-chi-bot @qiancai